Fix VMAT SCP MU scaling and clinical criteria logic#14
Merged
gourav3017 merged 1 commit intoPortPy-Project:masterfrom Nov 19, 2025
Merged
Fix VMAT SCP MU scaling and clinical criteria logic#14gourav3017 merged 1 commit intoPortPy-Project:masterfrom
gourav3017 merged 1 commit intoPortPy-Project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes a small set of fixes:
clinical_criterialogic when checking and modifying criteria.Changes
1. VMAT SCP MU scaling fix
In
portpy/photon/vmat_scp/vmat_scp_optimization.py:Adjust the lower-bound constraint on the interior beamlet intensities from:
to
This aligns MU handling within the SCP intermediate optimization with Eclipse’s MU scaling.
2. Clinical criteria handling
Both
modify_criterion()andcheck_criterion_exists()contained the same logical error:they compared a constraint key (string) to the entire constraint dictionary, which always evaluated to false.
The updated logic now: